Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Miscellaneous improvements #6132

Merged
merged 7 commits into from
Jan 17, 2022
Merged

ci: Miscellaneous improvements #6132

merged 7 commits into from
Jan 17, 2022

Conversation

Ouss4
Copy link
Contributor

@Ouss4 Ouss4 commented Jan 13, 2022

  1. Cache downloaded tools.
  2. Cancel duplicate jobs.
  3. Use current repo when linking the core, this allows users to test their code when creating PRs against their forks (for instance an error in an example sketch will build successfully in a fork workflow.)
  4. Cache Arduino IDE.
  5. Add workflow_dispatch to be able to trigger the workflow manually.

.github/workflows/push.yml Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
@Ouss4 Ouss4 force-pushed the misc_ci branch 3 times, most recently from 4e569a2 to e154907 Compare January 17, 2022 13:00
@me-no-dev
Copy link
Member

it is not necessary that the target mcu equals the third part of FQBN. This in our case currently is true, but if we want to test agains different boards (we will in near future) then scripts will not be able to tell what is the actual MCU and decide to skip the test.

@Ouss4
Copy link
Contributor Author

Ouss4 commented Jan 17, 2022

it is not necessary that the target mcu equals the third part of FQBN. This in our case currently is true, but if we want to test agains different boards (we will in near future) then scripts will not be able to tell what is the actual MCU and decide to skip the test.

How would this look like? espressif:esp32:esp32-devkitc for instance? What would the second part represent in this case?

@me-no-dev
Copy link
Member

first part is "manufacturer"m, second is "core" and third is the board. manufacturer and core come from the path of installation: ~/Arduino/hardware/[manufacturer]/[core]

Signed-off-by: Abdelatif Guettouche <[email protected]>
…fork or not.

This allows forks to run workflows with their own code.

Signed-off-by: Abdelatif Guettouche <[email protected]>
@Ouss4
Copy link
Contributor Author

Ouss4 commented Jan 17, 2022

first part is "manufacturer"m, second is "core" and third is the board. manufacturer and core come from the path of installation: ~/Arduino/hardware/[manufacturer]/[core]

Okay, thanks. If the boards we want to test against are Espressif's, we can still extract the chip name from the board's, but other manufacturers won't necessary follow the same naming conventions (and I think we also have few special cases).
I will drop this commit.

README.md Outdated Show resolved Hide resolved
@Ouss4 Ouss4 force-pushed the misc_ci branch 4 times, most recently from 770b954 to 84b85e1 Compare January 17, 2022 16:06
Signed-off-by: Abdelatif Guettouche <[email protected]>
Signed-off-by: Abdelatif Guettouche <[email protected]>
@me-no-dev me-no-dev merged commit 77756d8 into espressif:master Jan 17, 2022
@Ouss4 Ouss4 deleted the misc_ci branch January 17, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants