Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPIO refactoring #6259

Merged
merged 2 commits into from
Feb 16, 2022
Merged

GPIO refactoring #6259

merged 2 commits into from
Feb 16, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Feb 11, 2022 •
edited
Loading

Summary

GPIO now using ESP-IDF API on all chips.
LEDC interrupt fix removed - no longer needed.
Edited pins_arduino.h in variants according to changes in gpio.

Known issue with GPIO interrupt on chip Esp32s3. Will be fixed in ESP-IDF.
For now GPIO interrupts work only on CORE 0.

Impact

Close #6249
Close #6120

Related links

@P-R-O-C-H-Y
GPIO refactoring
7571718 
GPIO now using ESP-IDF API on all chips.
LEDC interrupt fix removed - no longer needed.
Edited pins_arduino.h in variants according to changes in gpio.
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Feb 11, 2022
@P-R-O-C-H-Y
Copy link
Member Author

P-R-O-C-H-Y commented Feb 11, 2022 •
edited
Loading

Still in progress, found some issues.
Fixed

@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as draft February 11, 2022 14:17
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as ready for review February 14, 2022 10:17
@VojtechBartoska VojtechBartoska added the Area: Peripherals API Relates to peripheral's APIs. label Feb 14, 2022
@VojtechBartoska VojtechBartoska added this to the 2.0.3 milestone Feb 14, 2022
@me-no-dev me-no-dev merged commit c7cc5c9 into espressif:master Feb 16, 2022
@Jason2866 Jason2866 mentioned this pull request Feb 27, 2022
Closed
@htmltiger htmltiger mentioned this pull request Mar 13, 2022
Closed
dok-net added a commit to dok-net/arduino-esp32 that referenced this pull request Mar 25, 2022
@dok-net
Revert "GPIO refactoring (espressif#6259)"
ce61070 
This partly reverts commit c7cc5c9.
dok-net added a commit to dok-net/arduino-esp32 that referenced this pull request Apr 3, 2022
@dok-net
Revert "GPIO refactoring (espressif#6259)"
a459875 
This partly reverts commit c7cc5c9.
@dok-net dok-net mentioned this pull request Apr 3, 2022
Merged
dok-net added a commit to dok-net/arduino-esp32 that referenced this pull request Apr 4, 2022
@dok-net
Amend "GPIO refactoring (espressif#6259)"
b40031f
me-no-dev pushed a commit that referenced this pull request Apr 5, 2022
@dok-net
Amend "GPIO refactoring (#6259)" (#6527)
6cfe461
@dok-net dok-net mentioned this pull request Apr 12, 2022
Closed
@jenscski jenscski mentioned this pull request Jul 25, 2022
Closed
@platypii
Copy link
Contributor

platypii commented Mar 4, 2023

I have an ESP32 project which was working fine, but stopped working when I updated arduino-esp32. I used git bisect to trace the regression to this commit. After this commit, my board would crash loop on start up. Nothing had changed in my project code. The error looked like:

__attachInterruptFunctionalArg(): GPIO ISR Service Failed To Start
gpio: gpio_install_isr_service(449): GPIO isr service already installed

After a lot of digging, I found the problem: I was calling attachInterrupt in the constructor of a global variable. So attachInterrupt was being called before setup(). Apparently that was okay before this PR, but does not work after this PR. Fixed my code by initializing my pins inside of setup, not before.

Sharing in case it helps others.

@P-R-O-C-H-Y P-R-O-C-H-Y deleted the GPIO_refactor branch April 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider Awaiting requested review from SuGlider

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

ESP32-S2 - can't toggle GPIO9 or GPIO11 after flashing Change GPIO to use ESP-IDF API (C)
4 participants
@P-R-O-C-H-Y @platypii @me-no-dev @VojtechBartoska