Fixes DHCP Server Lease Range for any AP Server Static IP Address #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@me-no-dev |
|
@SuGlider since it's already merged, please adjust the code and remove it here. |
|
@SuGlider will you finish this please? |
@me-no-dev - PR is finished for Arduino Core 2.0.3. I'll work on a separated PR that will allow the user to set IPV4 Range for DHCP. |
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an issue that prevents DHCP server to start if WiFi AP Mode is used with Static IP that is too close to the end of subnet range. Lease adresses range will overflow NetMask preventing DHCP Server to start, issuing error message
DHCPS Set Lease Failed! 0x5001.This PR fixes it and continues to consider the same previously coded assumptions about netmasking and DHCP leasing range size for AP mode.
Impact
None.
Related links
Fixes #6270