ESP32-S3 SDMMC support #6323
Merged
ESP32-S3 SDMMC support #6323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
commented
Feb 21, 2022
igrr
force-pushed
the
esp32-s3-support-sdmmc
branch
from
882484e
to
29942e1
Compare
|
There are still two issues on IDF side which need to be fixed in the IDF driver: espressif/esp-idf#8521 and espressif/esp-idf#8257. These will need to be fixed in IDF |
igrr
commented
Mar 14, 2022
| #define SDMMC_CLK 13 | ||
| #define SDMMC_CMD 11 | ||
| #define SDMMC_D0 14 | ||
| #define SDMMC_D1 12 | ||
| #define SDMMC_D2 10 | ||
| #define SDMMC_D3 9 | ||
| #define BOARD_MAX_SDMMC_FREQ SDMMC_FREQ_DEFAULT |
There was a problem hiding this comment.
To be removed after the above mentioned IDF issues are fixed and fixes are included into Arduino.
igrr
force-pushed
the
esp32-s3-support-sdmmc
branch
from
29942e1
to
a457204
Compare
|
To test on ESP32-S3-USB-OTG, apply the patch: diff --git a/variants/esp32s3/pins_arduino.h b/variants/esp32s3/pins_arduino.h
index 5cd22fa5..f906bd3f 100644
--- a/variants/esp32s3/pins_arduino.h
+++ b/variants/esp32s3/pins_arduino.h
@@ -64,4 +64,15 @@ static const uint8_t T14 = 14;
static const uint8_t DAC1 = 17;
static const uint8_t DAC2 = 18;
+
+#define BOARD_HAS_SDMMC
+#define SDMMC_CLK 36
+#define SDMMC_CMD 35
+#define SDMMC_D0 37
+#define SDMMC_D1 38
+#define SDMMC_D2 33
+#define SDMMC_D3 34
+
+#define BOARD_MAX_SDMMC_FREQ SDMMC_FREQ_DEFAULT
+
#endif /* Pins_Arduino_h */ |
|
I will actually add a whole board definition for ESP32-S3-USB-OTG, because it's an interesting case to have as example for board support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds SDMMC support for ESP32-S3.
Unlike ESP32, ESP32-S3 allows all SDMMC pins to be configured flexibly using GPIO matrix. A new function is added to SDMMC class to allow setting the pins.
Impact
Related links
SDMMC docs for S3: https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/api-reference/peripherals/sdmmc_host.html