feather esp32-s3 hardware definition and bootloader #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason2866
reviewed
Mar 20, 2022
me-no-dev
reviewed
Mar 25, 2022
me-no-dev
reviewed
Mar 25, 2022
me-no-dev
reviewed
Mar 25, 2022
…disabled) and upload (usb mode only)
|
@ladyada I have no more comments. We will merge this before Monday afternoon. Please make sure all is OK on your side with the boards by then :) |
|
thank you kindly, i have two pins i forgot on the qtpy - i will fix those tonight. the s3 is very exciting :) |
|
ok this should be ready to merge 🙏 |
|
done :) |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add hardware definition for new board
Impact
only affects the creation of new hardware (which is tested :)