Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for the ESP32-C6-DevKitC-1 #92

Merged
merged 5 commits into from
Apr 12, 2023

Conversation

linkedupbits
Copy link
Contributor

This PR adds support for the ESP32-C6-DevKitC-1. It has been tested uploading the binary outputs from esp-idf

src/esploader.ts Outdated Show resolved Hide resolved
@linkedupbits
Copy link
Contributor Author

I have also tested this using a local esphome-web-tools dev container, after building a esptool-js-0.2.1.tgz and placing it locally.
The local esphome-web-tools is then able to successfully connect to the C6 via the local COM port and show trace logs.
(Uploading a base ESPHome image is not working yet)

@linkedupbits
Copy link
Contributor Author

@balloob - with the reverted line endings, is there anything outstanding on this PR?

@balloob
Copy link
Contributor

balloob commented Mar 26, 2023

I'm sorry, I just hang around this repo as we rely on it downstream for ESP Web Tools. I am not able to review/merge PRs.

@linkedupbits
Copy link
Contributor Author

linkedupbits commented Mar 26, 2023

I'm sorry, I just hang around this repo as we rely on it downstream for ESP Web Tools. I am not able to review/merge PRs.

Makes sense - the reason I am trying to get this merged is for eventual ESPHome support.

If you don’t mind, to incorporate into a dev ESPHome:

  • I have built this into a tgz, and included it into a local esp-web-tools, which runs and recognises the Esp32 correctly and uploads firmware
  • I am having difficulty then building/running a local ESPHome referencing the local esp-web-tools, that uses the local esptools-js.

is there a guide for a setting up a “fully local “ dev stack, to make integrating new chipsets easier for new starters?

@linkedupbits
Copy link
Contributor Author

@brianignacio5 are you able to review this PR?

@brianignacio5
Copy link
Collaborator

brianignacio5 commented Apr 4, 2023

Could you please check the lint errors ? Just run npm run lint locally.

@linkedupbits
Copy link
Contributor Author

linkedupbits commented Apr 4, 2023

npm run lint

@brianignacio5 : local lint output (after 8ec78d5 and 23242c1):

npm run lint

> [email protected] lint
> eslint . --ext .ts


/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32c3.ts
  70:34  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  74:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32c6.ts
  70:34  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  74:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32s2.ts
  78:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

/home/stephen/esp/linkedupbits/esptool-js/src/targets/esp32s3.ts
  43:37  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  46:34  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars
  49:33  warning  'loader' is defined but never used  @typescript-eslint/no-unused-vars

✖ 8 problems (0 errors, 8 warnings)

Should be better now.

@brianignacio5 brianignacio5 merged commit f1c3e27 into espressif:main Apr 12, 2023
@brianignacio5
Copy link
Collaborator

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants