-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important fatal errors should print to stderr (ESPTOOL-863) #981
Labels
Comments
github-actions
bot
changed the title
Important fatal errors should print to stderr
Important fatal errors should print to stderr (ESPTOOL-863)
May 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Operating System
(relevant to most)
Esptool Version
4.7 (applicable to all)
Python Version
3.12.3 (applicable to all)
Full Esptool Command Line that Was Run
No response
Esptool Output
What is the Expected Behaviour?
esptool should print the more-helpful error message on STDERR (which currently only goes to STDOUT):
More Information
Some fatal errors also print important messages the user should see
esptool/esptool/loader.py
Line 35 in 4394a65
esptool/esptool/loader.py
Line 61 in 4394a65
However, these
print()
to stdout, and in many cases (e.g.arduino-cli
), esptool is run with stdout suppressed, so all you see is the native Python stack trace error.Probably instead of
print()
andraise
, these should raise an error with the error message, the way this does:esptool/esptool/loader.py
Line 44 in 4394a65
Other Steps to Reproduce
No response
The text was updated successfully, but these errors were encountered: