Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest_embedded_arduino/app.py: Add ESP32-S3 to the list of supported chips (RDT-107) #68

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

Ouss4
Copy link
Contributor

@Ouss4 Ouss4 commented Mar 10, 2022

Include ESP32-S3 to the list of supported chips in Arduino.

@igrr
Copy link
Member

igrr commented Mar 10, 2022

LGTM, just one general question. These offsets will probably depend on the specific partition table selected in Tools menu? (Or in the FQBN string if building via arduino-builder.) Do you see a way how we can avoid hardcoding these offsets in pytest-embedded and pull this information from arduino?

In IDF there is a "flasher_args" JSON file produced by the build system, which includes flashing offsets. I wonder if we need to generate something similar in Arduino as well.

@github-actions github-actions bot changed the title pytest_embedded_arduino/app.py: Add ESP32-S3 to the list of supported chips pytest_embedded_arduino/app.py: Add ESP32-S3 to the list of supported chips (RDT-107) Mar 10, 2022
@Ouss4
Copy link
Contributor Author

Ouss4 commented Mar 10, 2022

In IDF there is a "flasher_args" JSON file produced by the build system, which includes flashing offsets. I wonder if we need to generate something similar in Arduino as well.

That would be ideal. Otherwise we'll have to do the same as the Arduino build system to extract the partition table from the FQBN.
Arduino build system generates a build.options.json file that includes the FQBN but not the offsets. Not sure how to do that for now.
cc. @me-no-dev

@me-no-dev
Copy link
Member

we don't even do it in Arduino currently, but builder should have copied the selected partition scheme to [test]/build/partitions.csv. If you need to change something, please do it on the esp32-s3-support branch.

@Ouss4
Copy link
Contributor Author

Ouss4 commented Mar 14, 2022

we don't even do it in Arduino currently, but builder should have copied the selected partition scheme to [test]/build/partitions.csv. If you need to change something, please do it on the esp32-s3-support branch.

We'll think about that after this one is done.

@hfudev is the failing test supposed to pass? Python 3.10 is passing but not 3.6.

@hfudev
Copy link
Member

hfudev commented Mar 14, 2022

@Ouss4

@hfudev is the failing test supposed to pass? Python 3.10 is passing but not 3.6.

I think it's related to #69.

Let's merge this when you think this MR is ready.

@Ouss4
Copy link
Contributor Author

Ouss4 commented Mar 14, 2022

@hfudev thanks for the explanation. This one is ready to be merged.

@hfudev hfudev merged commit 8c51cdb into espressif:main Mar 14, 2022
@Ouss4 Ouss4 deleted the arduino-esp32s3 branch March 14, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants