Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd-raft-zap logger fixes. #12775

Merged
merged 2 commits into from
Mar 14, 2021
Merged

etcd-raft-zap logger fixes. #12775

merged 2 commits into from
Mar 14, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Mar 14, 2021 

Unify logic of building raft-loggers for etcd.

1. We had the same code copied 3 times.
2. The code was not reusing existing logger if this one is given.

The benefit of this change is that all integration tests are using the same logger.

@ptabor
Merge get_logger() & Logger() method.
44bd223
@ptabor
Unify logic of building raft-loggers for etcd.
1e7c180 
1. We had the same code copied 3 times.
2. For no good reason the code was not reusing existing logger if this one is given.
@gyuho gyuho merged commit e599f4a into etcd-io:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptabor @gyuho