fix semgrep errors, update semver

ethereum-optimism · Oct 10, 2024 · bc40774 · bc40774
1 parent 0d851d1
commit bc40774
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/packages/contracts-bedrock/semver-lock.json b/packages/contracts-bedrock/semver-lock.json
@@ -116,8 +116,8 @@
  "sourceCodeHash": "0x5e58b7c867fafa49fe39d68d83875425e9cf94f05f2835bdcdaa08fc8bc6b68e"
  },
  "src/L2/OptimismSuperchainERC20Factory.sol": {
- "initCodeHash": "0x524bc58927ca60ba2fbc4b036ad00c5055758d5c5b2ebb3d75cb9b996175f2cb",
- "sourceCodeHash": "0x155a4b22ff8e266560d1fae72e1db7fc164afd84b8a81afb74c69414e0d5438e"
+ "initCodeHash": "0x43ec413140b05bfb83ec453b0d4f82b33a2d560bf8c76405d08de17565b87053",
+ "sourceCodeHash": "0x1e02d78a4e7ee93a07f7af7a78fe1773d0e87711f23a4ccd10a8692b47644a34"
  },
  "src/L2/SequencerFeeVault.sol": {
  "initCodeHash": "0xcaadbf08057b5d47f7704257e9385a29e42a7a08c818646d109c5952d3d35218",

diff --git a/packages/contracts-bedrock/snapshots/abi/OptimismSuperchainERC20Factory.json b/packages/contracts-bedrock/snapshots/abi/OptimismSuperchainERC20Factory.json
@@ -37,15 +37,15 @@
  "inputs": [
  {
  "internalType": "address",
- "name": "superchainToken",
+ "name": "_superchainToken",
  "type": "address"
  }
  ],
  "name": "deployments",
  "outputs": [
  {
  "internalType": "address",
- "name": "remoteToken",
+ "name": "remoteToken_",
  "type": "address"
  }
  ],

diff --git a/packages/contracts-bedrock/src/L2/OptimismSuperchainERC20Factory.sol b/packages/contracts-bedrock/src/L2/OptimismSuperchainERC20Factory.sol
@@ -16,7 +16,7 @@ import { CREATE3 } from "@rari-capital/solmate/src/utils/CREATE3.sol";
 contract OptimismSuperchainERC20Factory is IOptimismERC20Factory, ISemver {
  /// @notice Mapping of the deployed OptimismSuperchainERC20 to the remote token address.
  /// This is used to keep track of the token deployments.
- mapping(address superchainToken => address remoteToken) public deployments;
+ mapping(address _superchainToken => address remoteToken_) public deployments;
 
  /// @notice Emitted when an OptimismSuperchainERC20 is deployed.
  /// @param superchainToken Address of the SuperchainERC20 deployment.
@@ -27,8 +27,8 @@ contract OptimismSuperchainERC20Factory is IOptimismERC20Factory, ISemver {
  );
 
  /// @notice Semantic version.
- /// @custom:semver 1.0.0-beta.2
- string public constant version = "1.0.0-beta.2";
+ /// @custom:semver 1.0.0-beta.3
+ string public constant version = "1.0.0-beta.3";
 
  /// @notice Deploys a OptimismSuperchainERC20 Beacon Proxy using CREATE3.
  /// @param _remoteToken Address of the remote token.

diff --git a/packages/contracts-bedrock/src/L2/interfaces/IOptimismSuperchainERC20Factory.sol b/packages/contracts-bedrock/src/L2/interfaces/IOptimismSuperchainERC20Factory.sol
@@ -11,7 +11,7 @@ interface IOptimismSuperchainERC20Factory is IOptimismERC20Factory, ISemver {
  address indexed superchainToken, address indexed remoteToken, address deployer
  );
 
- function deployments(address superchainToken) external view override returns (address remoteToken);
+ function deployments(address _superchainToken) external view override returns (address remoteToken_);
  function version() external view override returns (string memory);
  function deploy(
  address _remoteToken,