feat: ban deposits interop #11481
Merged
feat: ban deposits interop #11481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: not cross l2 inbox error
* refactor: not cross l2 inbox error
…nd/optimism into feat/ban-deposits-interop
* feat: add is deposit test
* fix: stick to natspec standards
This reverts commit e162361.
…mism/optimism into feat/ban-deposits-interop
* refactor: move the isthmus test logic to the l1 block test contract
* chore: remove unused imports
…mism/optimism into feat/ban-deposits-interop
…mism/optimism into feat/ban-deposits-interop
* feat: add benchmark test for deposits complete function
0xDiscotech
commented
Aug 14, 2024
0xDiscotech
requested review from
smartcontracts
and removed request for
a team
skeletor-spaceman
merged commit 09c549c
into
ethereum-optimism:feat/ban-deposits-interop
4 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of the features you're adding in this pull request.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata