Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scaffolding for DeployAuthSystemInput #11889

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Sep 12, 2024

TL;DR

Introduced a new authentication system deployment script and associated test files.

This PR is limited to adding the DeployAuthSystemInput file, with configuration for a single safe, in order to establish a basic scaffolding to build on.

Copy link
Contributor Author

maurelian commented Sep 12, 2024

@maurelian maurelian marked this pull request as ready for review September 12, 2024 18:25
@maurelian maurelian requested a review from a team as a code owner September 12, 2024 18:25
@maurelian maurelian requested a review from mds1 September 12, 2024 18:25
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after addressing the comments

Copy link
Contributor

semgrep-app bot commented Sep 13, 2024

Semgrep found 6 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

@maurelian maurelian added this pull request to the merge queue Sep 13, 2024
Merged via the queue into develop with commit 3ba35fa Sep 13, 2024
61 checks passed
@maurelian maurelian deleted the maur/opsm/das-input branch September 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants