Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Additional DeployImplementations.s.sol tests #11914

Merged
merged 2 commits into from
Sep 15, 2024
Merged

fix: Additional DeployImplementations.s.sol tests #11914

merged 2 commits into from
Sep 15, 2024

Conversation

blmalone
Copy link
Contributor

Additional tests for DeployImplementations.s.sol Input. Specifically for inferring proxy admin from superchainConfig.

Related PR: #11875

@blmalone blmalone self-assigned this Sep 14, 2024
@blmalone blmalone requested a review from a team as a code owner September 14, 2024 06:20
mds1
mds1 approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits to make sure the test names follow the style guide, I'll apply these and merge

@blmalone blmalone added this pull request to the merge queue Sep 15, 2024
Merged via the queue into develop with commit 8341f34 Sep 15, 2024
60 checks passed
@blmalone blmalone deleted the bm/additional-tests-proxied-opsm branch September 15, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

@skeletor-spaceman skeletor-spaceman Awaiting requested review from skeletor-spaceman skeletor-spaceman is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees

@blmalone blmalone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blmalone @mds1