Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: Fix compile error #11933

Merged
merged 2 commits into from
Sep 17, 2024
Merged

op-e2e: Fix compile error #11933

merged 2 commits into from
Sep 17, 2024

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Sep 16, 2024

Description

Fix compile error in super system - seems to have been caused by a merge error. Adds go-lint as a dependency of bedrock-go-tests so it is required before merging.

@ajsutton ajsutton requested a review from a team as a code owner September 16, 2024 23:25
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the interop package might be getting skipped. Will look into that, approving PR to fix up develop asap.

@protolambda protolambda added this pull request to the merge queue Sep 16, 2024
@ajsutton
Copy link
Contributor Author

I think it's just that go-lint wasn't blocking merging before. It fails for me locally and fails in CI, just GitHub merged it anyway.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@ajsutton ajsutton added this pull request to the merge queue Sep 16, 2024
Merged via the queue into develop with commit 66bfe67 Sep 17, 2024
64 checks passed
@ajsutton ajsutton deleted the aj/fix-lint branch September 17, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants