Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Drop unnecessary wakeup field reset #12095

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Sep 24, 2024

Description

Cut unnecessary wakeup reset logic.

Tests

Existing tests should provide coverage.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (8b76931) to head (c48d154).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12095      +/-   ##
===========================================
- Coverage    78.87%   78.86%   -0.02%     
===========================================
  Files           41       41              
  Lines         3437     3435       -2     
===========================================
- Hits          2711     2709       -2     
  Misses         557      557              
  Partials       169      169              
Flag Coverage Δ
cannon-go-tests 78.86% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cannon/mipsevm/multithreaded/mips.go 95.67% <100.00%> (-0.03%) ⬇️

@mbaxter mbaxter requested a review from Inphi September 24, 2024 20:02
@mbaxter mbaxter marked this pull request as ready for review September 24, 2024 20:02
@mbaxter mbaxter requested review from a team as code owners September 24, 2024 20:02
@mbaxter mbaxter added this pull request to the merge queue Sep 24, 2024
Merged via the queue into ethereum-optimism:develop with commit 712b760 Sep 24, 2024
62 checks passed
@mbaxter mbaxter deleted the cannon/cleanup/drop-unnecessary-wakeup-reset branch September 24, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants