test: Transfer to finalSystemOwner rather than SystemOwnerSafe

[maurelian]

test: Transfer to finalSystemOwner rather than SystemOwnerSafe

test(deploy): Remove SystemOwnerSafe

Instead of deploying a SystemOwnerSafe at the start, then performing
all ProxyAdmin and other admin actions via that Safe, we now
simply setup the system using deploy (msg.sender) and then transfer
to the finalSystemOwner at the end.

[maurelian]

• feat: Extract deployment of pre-v1.6.0 code #12233
• feat: Add a test to simplify deploy script testing #12235
• feat: deployImplementations and depImplementationsInterop #12226
• feat: Use DeploySuperchain script in Deploy.s.sol #12203
• test(deploy): Deploy a distinct ProxyAdmin for Superchain contracts #12130
• test: Transfer to finalSystemOwner rather than SystemOwnerSafe #12116 👈
• feat(deploy): deploy implementations before proxies #12114
• test: move OPCM tests to own dir #12110
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maurelian and the rest of your teammates on Graphite

[mds1]

This LGTM, but CI is failing—unsure if it's a flake or legit failure

Also cc @smartcontracts to make sure there's no reason we shouldn't be changing the FPACOPS scripts

[maurelian]

This LGTM, but CI is failing—unsure if it's a flake or legit failure

Should be good now.

Also cc @smartcontracts to make sure there's no reason we shouldn't be changing the FPACOPS scripts

FWIW it's literally just a variable rename. But we revert the changes to those files if necessary.

[maurelian]

Merge activity

• Sep 27, 11:38 AM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..