Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Test for existing OPCM #12257

Merged
merged 12 commits into from
Oct 3, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Oct 2, 2024

Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars:

  • SEPOLIA_RPC_URL: RPC URL for a Sepolia node.
  • ENABLE_ANVIL: Set to true to enable the test.

In CI, the test uses our internal CI RPC nodes.

@mslipper mslipper requested review from a team as code owners October 2, 2024 16:28
Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars:

- `SEPOLIA_RPC_URL`: RPC URL for a Sepolia node.
- `ENABLE_ANVIL`: Set to `true` to enable the test.

In CI, the test uses our internal CI RPC nodes.
@mslipper mslipper force-pushed the feat/existing-chain-unit-test branch from 6abe51e to 33a7cd4 Compare October 2, 2024 16:28
@mslipper
Copy link
Collaborator Author

mslipper commented Oct 2, 2024

Oof: Screenshot 2024-10-02 at 10 33 22 AM

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.00%. Comparing base (00f965d) to head (7b32680).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12257   +/-   ##
========================================
  Coverage    72.00%   72.00%           
========================================
  Files           50       50           
  Lines         3912     3912           
========================================
  Hits          2817     2817           
  Misses         910      910           
  Partials       185      185           
Flag Coverage Δ
cannon-go-tests 72.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thank you!

@mds1 mds1 enabled auto-merge October 2, 2024 22:33
@mds1 mds1 added this pull request to the merge queue Oct 3, 2024
Merged via the queue into develop with commit a83c375 Oct 3, 2024
62 checks passed
@mds1 mds1 deleted the feat/existing-chain-unit-test branch October 3, 2024 00:55
mininny pushed a commit to testinprod-io/optimism that referenced this pull request Oct 3, 2024
* op-deployer: Test for existing OPCM

Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars:

- `SEPOLIA_RPC_URL`: RPC URL for a Sepolia node.
- `ENABLE_ANVIL`: Set to `true` to enable the test.

In CI, the test uses our internal CI RPC nodes.

* goimports

* ensure streams close

* lint

* run anvil as part of unit not integration tests

* simplify

* remove foundry from kurtosis

* use auto mine

* mount artifacts

* redeploy OPCM

* comment
protolambda pushed a commit that referenced this pull request Oct 7, 2024
* op-deployer: Test for existing OPCM

Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars:

- `SEPOLIA_RPC_URL`: RPC URL for a Sepolia node.
- `ENABLE_ANVIL`: Set to `true` to enable the test.

In CI, the test uses our internal CI RPC nodes.

* goimports

* ensure streams close

* lint

* run anvil as part of unit not integration tests

* simplify

* remove foundry from kurtosis

* use auto mine

* mount artifacts

* redeploy OPCM

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants