-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-deployer: Test for existing OPCM #12257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars: - `SEPOLIA_RPC_URL`: RPC URL for a Sepolia node. - `ENABLE_ANVIL`: Set to `true` to enable the test. In CI, the test uses our internal CI RPC nodes.
mslipper
force-pushed
the
feat/existing-chain-unit-test
branch
from
October 2, 2024 16:28
6abe51e
to
33a7cd4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12257 +/- ##
========================================
Coverage 72.00% 72.00%
========================================
Files 50 50
Lines 3912 3912
========================================
Hits 2817 2817
Misses 910 910
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. |
…feat/existing-chain-unit-test
mds1
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, thank you!
zhwrd
approved these changes
Oct 3, 2024
mininny
pushed a commit
to testinprod-io/optimism
that referenced
this pull request
Oct 3, 2024
* op-deployer: Test for existing OPCM Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars: - `SEPOLIA_RPC_URL`: RPC URL for a Sepolia node. - `ENABLE_ANVIL`: Set to `true` to enable the test. In CI, the test uses our internal CI RPC nodes. * goimports * ensure streams close * lint * run anvil as part of unit not integration tests * simplify * remove foundry from kurtosis * use auto mine * mount artifacts * redeploy OPCM * comment
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
* op-deployer: Test for existing OPCM Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars: - `SEPOLIA_RPC_URL`: RPC URL for a Sepolia node. - `ENABLE_ANVIL`: Set to `true` to enable the test. In CI, the test uses our internal CI RPC nodes. * goimports * ensure streams close * lint * run anvil as part of unit not integration tests * simplify * remove foundry from kurtosis * use auto mine * mount artifacts * redeploy OPCM * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars:
SEPOLIA_RPC_URL
: RPC URL for a Sepolia node.ENABLE_ANVIL
: Set totrue
to enable the test.In CI, the test uses our internal CI RPC nodes.