fix(ct): error in deploy script #12264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartcontracts
requested review from
refcell and
mds1
and removed request for
refcell
maurelian
reviewed
Oct 2, 2024
smartcontracts
force-pushed
the
sc/fix-kontrol-deploy
branch
3 times, most recently
from
fbba62d
to
18b6f77
Compare
mds1
reviewed
Oct 2, 2024
Fixes an error in the deploy script that was recently introduced. SuperchainProxyAdmin was being set twice and ownership was being set incorrectly.
smartcontracts
force-pushed
the
sc/fix-kontrol-deploy
branch
from
18b6f77
to
679aa0c
Compare
maurelian
approved these changes
Oct 2, 2024
mininny
pushed a commit
to testinprod-io/optimism
that referenced
this pull request
Oct 3, 2024
Fixes an error in the deploy script that was recently introduced. SuperchainProxyAdmin was being set twice and ownership was being set incorrectly.
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fixes an error in the deploy script that was recently introduced. SuperchainProxyAdmin was being set twice and ownership was being set incorrectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error in the deploy script that was recently introduced. SuperchainProxyAdmin was being set twice and ownership was being set incorrectly.