feat(op-deployer): add test for block time override #12276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
force-pushed
the
feat/block-time-override
branch
from
a207d8f
to
d6bd510
Compare
mds1
force-pushed
the
feat/block-time-override
branch
from
d6bd510
to
faf3071
Compare
mds1
changed the title
mds1
changed the title
blmalone
approved these changes
Oct 3, 2024
mininny
pushed a commit
to testinprod-io/optimism
that referenced
this pull request
Oct 3, 2024
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test that block time can be overridden in the intent using the
globalDeployOverridessection. For example:@mslipper Let me know if there's a better way to add this test. I duplicated a lot of code from
TestEndToEndApply, but can dedupe some setup code if this is the right place for this test