Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sol-style-malformed-revert locally #12341

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

smartcontracts
Copy link
Contributor

Adds sol-style-malformed-revert to local semgrep and fixes the rule so that it actually works. Fixes a couple of findings that the updated rule discovered.

Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smartcontracts smartcontracts force-pushed the sc/sol-malformed-revert branch 2 times, most recently from ecaac5b to b8707a0 Compare October 7, 2024 16:40
Adds sol-style-malformed-revert to local semgrep and fixes the
rule so that it actually works. Fixes a couple of findings that
the updated rule discovered.
@smartcontracts smartcontracts added this pull request to the merge queue Oct 7, 2024
Merged via the queue into develop with commit 6d874d5 Oct 7, 2024
61 checks passed
@smartcontracts smartcontracts deleted the sc/sol-malformed-revert branch October 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants