Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use interface and deployutils for remaining contracts in l2genesis #12399

Merged
merged 2 commits into from
Oct 10, 2024
Merged

use interface and deployutils for remaining contracts in l2genesis #12399

merged 2 commits into from
Oct 10, 2024
+126 −52

Conversation

AmadiMichael
Copy link
Member

@AmadiMichael AmadiMichael commented Oct 9, 2024 •
edited
Loading

Use interface and DeployUtils for remaining contracts in L2genesis.s.sol. This greatly helps improve compilation time.

@AmadiMichael AmadiMichael requested a review from a team as a code owner October 9, 2024 22:32
smartcontracts
smartcontracts approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@smartcontracts smartcontracts added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 9bbc54b Oct 10, 2024
61 checks passed
@smartcontracts smartcontracts deleted the sc/interface-use-in-l2genesis branch October 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmadiMichael @smartcontracts