Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Fee Recipients and Gas Params added to intent #12404

Merged

Conversation

blmalone
Copy link
Contributor

@blmalone blmalone commented Oct 10, 2024

Issue originating from: https:/ethereum-optimism/platforms-team/issues/284

Fee Recipients

The existing integration test: op-chain-ops/deployer/integration_test/apply_test.go applies a pipeline of tasks for op-deployer. As we know, the last task in the pipeline after performing an apply is generate-l2-genesis (see here).

In this PR, I'm adding configurable fee recipient addresses to the intent file. These addresses will be injected as immutables into three predeploy contracts:

  • BaseFeeVault
  • L1FeeVault
  • SequencerFeeVault

In the apply_test.go integration test, I'm verifying that these addresses exist in the runtime bytecode of the three contracts mentioned above. This existence check is a best effort check to ensure that the immutables were injected correctly into the contracts.

Gas Params

Params defined in this PR have been taken from here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone marked this pull request as ready for review October 10, 2024 20:24
@blmalone blmalone requested review from a team as code owners October 10, 2024 20:24
@blmalone blmalone requested review from protolambda, mds1 and bitwiseguy and removed request for protolambda October 10, 2024 20:24
op-chain-ops/deployer/init.go Outdated Show resolved Hide resolved
Copy link
Contributor

semgrep-app bot commented Oct 11, 2024

Semgrep found 1 err-todo finding:

  • op-program/client/l2/engineapi/l2_engine_api.go

TODO in error handling code

Ignore this finding from err-todo.

Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's get a review from @bitwiseguy before merging

@tynes tynes added this pull request to the merge queue Oct 11, 2024
Merged via the queue into develop with commit 86c37b9 Oct 11, 2024
60 checks passed
@tynes tynes deleted the 10-10-op-deployer_fee_recipients_and_gas_params_added_to_intent branch October 11, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants