Fix definition of predeploy namespace #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a bug, there are a total of 2048 predeploys, that is bigger than a 1 byte namespace |
tynes
reviewed
Sep 18, 2024
specs/protocol/predeploys.md
Outdated
| @@ -39,7 +39,7 @@ network forking. | |||
|
|
|||
| Predeploy addresses exist in 1 byte namespace `0x42000000000000000000000000000000000000xx`. | |||
| Proxies are set at each possible predeploy address except for the | |||
| `GovernanceToken` and the `ProxyAdmin`. | |||
| `GovernanceToken`. | |||
There was a problem hiding this comment.
I believe this should be updated, i believe weth has no proxy
There was a problem hiding this comment.
Yes, double checked here
https:/ethereum-optimism/optimism/blob/develop/packages/contracts-bedrock/src/libraries/Predeploys.sol#L141-L145
and updated here fce5a99.
Updated here 51b1497 |
geoknee
changed the title
tynes
reviewed
Oct 9, 2024
specs/protocol/predeploys.md
Outdated
| Predeploy addresses exist in 1 byte namespace `0x42000000000000000000000000000000000000xx`. | ||
| Proxies are set at each possible predeploy address except for the | ||
| `GovernanceToken` and the `ProxyAdmin`. | ||
| Predeploy addresses exist in a prefixed namespace `0x420xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx`. |
There was a problem hiding this comment.
Don't you think that we should only use x in the least significant 3 nibbles to represent the fact that they are the only things that can change?
The deleted sentence contradicts the rest of the document, which states that the proxyadmin is itself a proxied contract.
geoknee
force-pushed
the
geoknee-patch-2
branch
from
12cf4cf
to
db54dd2
Compare
geoknee
force-pushed
the
geoknee-patch-2
branch
from
db54dd2
to
4f2b9a3
Compare
tynes
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by question:
Has it always been the case that predeploys live in a 1 byte namespace?
I think this is a counterexample https://optimistic.etherscan.io/address/0x4200000000000000000000000000000000000800