interop: change SuperchainERC20 function naming to be Superchain neutral #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xParticle
requested review from
tynes,
protolambda,
ajsutton,
sebastianst and
mslipper
as code owners
tynes
approved these changes
Oct 3, 2024
|
|
||
| ```solidity | ||
| event SuperchainMinted(address indexed _to, uint256 _amount) | ||
| event CrosschainMinted(address indexed _to, uint256 _amount) |
There was a problem hiding this comment.
This doesn't really matter but just want to note that the main optimism repository doesn't prefix event parameters with underscores.
e.g. in this implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the
__superchainMintand__superchainBurnfunctions to be cross-chain neutral and extensible to other L2s.These PR changes the names to
__crosschainMintand__crosschainBurn. The same for theCrosschainMintedandCrosschainBurntevents. Moreover, this interface gets renamed toICrosschainERC20andSuperchainERC20will extend from it to make the functions only callable by theSuperchainERC20Bridge.