Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP1 formatting improvements #1510

Merged
merged 5 commits into from
Jan 10, 2019
Merged

EIP1 formatting improvements #1510

merged 5 commits into from
Jan 10, 2019

Conversation

axic
Copy link
Member

@axic axic commented Oct 18, 2018 •
edited
Loading

@axic
Copy link
Member Author

axic commented Oct 18, 2018

Please do not squash merge because then it is hard to follow the diff.

@axic
Copy link
Member Author

axic commented Nov 8, 2018

Ping @Arachnid @Souptacular @nicksavers @gcolvin

@axic
Copy link
Member Author

axic commented Jan 4, 2019

Ping @Arachnid @Souptacular @nicksavers @gcolvin 😉

@Arachnid Arachnid merged commit b17d0d6 into ethereum:master Jan 10, 2019
@axic axic deleted the eip1-formatting branch January 10, 2019 20:20
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
@axic @ilanolkies
EIP1 formatting improvements (ethereum#1510)
321b2a8 
* Format the author header more nicely

* Use code highlighting on header fields

* Include proper headings for the header descriptions

* Group discussions-to requiements in a single place

* Clarify date formats in a single place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arachnid Arachnid Arachnid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @Arachnid