Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-1: Add adoptable field #5533

Closed
wants to merge 12 commits into from
Closed

Update EIP-1: Add adoptable field #5533

wants to merge 12 commits into from
+11 −1

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented Aug 24, 2022 •
edited
Loading

Reopening the discussion from #5463.

I merged without waiting for sufficient consensus, so I've reverted that PR, and opened this one.

@SamWilsn SamWilsn requested a review from eth-bot as a code owner August 24, 2022 20:49
@Pandapip1 @SamWilsn
Add adoptable field (ethereum#5463)
6ae83a8 
* Add resuscitatable field

* Add EIP-1 description

* Update EIPS/eip-1.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-1.md

Co-authored-by: Sam Wilson <[email protected]>

* Update eip-template.md

* Update eip-1.md

* Clear up what is considered "abandoned"

* Update eip-template.md

Co-authored-by: Sam Wilson <[email protected]>
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 24, 2022 •
edited
Loading

🛑 eip-review-bot failed for an unknown reason. Please see logs for more details, and report this issue at the eip-review-bot repository.

Pandapip1
Pandapip1 previously approved these changes Aug 24, 2022
View reviewed changes
@Pandapip1
Copy link
Member

@eth-bot rerun

@lightclient
Copy link
Member

I don't think this provides much value. It should simply be left up to editor discretion if a stagnant EIP can be reassigned. And I generally don't think that should happen unless the original author agrees.

@github-actions github-actions bot added c-update Modifies an existing proposal e-number Waiting on EIP Number assignment t-process" labels Aug 26, 2022
@Pandapip1
Copy link
Member

Pandapip1 commented Aug 26, 2022 •
edited
Loading

I generally don't think that should happen unless the original author agrees.

This flag is basically the author in advance stating "Yes, I am okay with someone else taking over this proposal." EIP Editors still have to approve to move it out of stagnant.

@Pandapip1
Copy link
Member

Also - this flag is optional. Anyone can choose to not have their EIP adoptable.

@Pandapip1 Pandapip1 changed the title Add adoptable field (#5463) Update EIP-1: Add adoptable field (#5463) Aug 28, 2022
@Pandapip1 Pandapip1 changed the title Update EIP-1: Add adoptable field (#5463) Update EIP-1: Add adoptable field Aug 28, 2022
@github-actions github-actions bot added s-draft This EIP is a Draft t-process labels Aug 28, 2022
@SamWilsn
Copy link
Contributor Author

SamWilsn commented Sep 2, 2022

I am, as usual, torn on this proposal.

I dislike reassigning proposals to new authors, but I equally dislike abandoning a well-known EIP number just because the authors can't be reached.

I would feel more comfortable if the authors opt-in to the adoption process over just reassigning without their permission.

@Pandapip1
Copy link
Member

I would feel more comfortable if the authors opt-in to the adoption process over just reassigning without their permission.

Should the adoptable field be by default set to false then?

@Pandapip1
Copy link
Member

Pandapip1 commented Apr 17, 2023 •
edited
Loading

Since enough people objected, I've set the adoptable entry in the template to be default-false, so that new EIPs are opt-in instead of opt-out.

This is a reminder: existing EIPs are, have been, and will always be opt-in.

@github-actions
Copy link

The commit 6be8d02 (as a parent of 303a47f) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 17, 2023
@github-actions github-actions bot removed the w-stale Waiting on activity label Apr 18, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 2, 2023
@Pandapip1
Copy link
Member

Still would like this.

@github-actions github-actions bot removed the w-stale Waiting on activity label May 3, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 17, 2023
@github-actions
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jun 28, 2023
@Pandapip1
Copy link
Member

Would like to reopen this.

@Pandapip1 Pandapip1 reopened this Jul 22, 2023
@github-actions github-actions bot removed the w-stale Waiting on activity label Jul 23, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 7, 2023
@Pandapip1
Copy link
Member

Bump...

@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 12, 2023
@poojaranjan poojaranjan mentioned this pull request Aug 22, 2023
Closed
12 tasks
@SamWilsn
Copy link
Contributor Author

I thought we had decided we weren't doing this?

@lightclient
Copy link
Member

I also thought we agreed not to do this

@Pandapip1
Copy link
Member

I thought we had decided we weren't doing this?

I thought I had simply stopped bringing it up. I probably misremembered then. Closing.

@Pandapip1 Pandapip1 closed this Aug 27, 2023
@Pandapip1
Copy link
Member

FWIW I would still like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv left review comments

@Pandapip1 Pandapip1 Pandapip1 left review comments

@mspaansen mspaansen mspaansen approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

@axic axic Awaiting requested review from axic

@lightclient lightclient Awaiting requested review from lightclient

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-draft This EIP is a Draft t-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamWilsn @eth-bot @Pandapip1 @lightclient @xinbenlv @mspaansen