Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-721 Non-Fungible Token Standard #841

Merged
merged 54 commits into from
Mar 9, 2018
Merged

EIP-721 Non-Fungible Token Standard #841

merged 54 commits into from
Mar 9, 2018

Commits on Jan 24, 2018

  1. EIP-721 Deed Standard 

    # TO DO:

- [ ] Get to status accepted
- [ ] Write test cases
- [ ] Write implementation (on OpenZeppelin?)
- [ ] Get to ​status final
    @fulldecent
    fulldecent authored Jan 24, 2018
    Configuration menu
    Copy the full SHA
    31ed49e View commit details
    Browse the repository at this point in the history

  2. Correct spelling errors and interface name, thanks @Beskhue

    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    4f71a02 View commit details
    Browse the repository at this point in the history

  3. Add "title" as considered alternative, thanks @TCOA

    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    29f88cc View commit details
    Browse the repository at this point in the history

  4. Undo time travel, thanks @pirapira

    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    e28b0ee View commit details
    Browse the repository at this point in the history

  5. "This is a" language, thanks @pirapira

    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    2fd4768 View commit details
    Browse the repository at this point in the history

  6. At risk of making this more boring to read, remove flavor text, thanks … 

    …@TCOA
    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    f3765be View commit details
    Browse the repository at this point in the history

  7. Clarify real estate transferrence fees, thank you @TCOA

    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    001b67b View commit details
    Browse the repository at this point in the history

  8. Use "unusable", thanks @TCOA

    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    c39a9f5 View commit details
    Browse the repository at this point in the history

  9. occurred

    @fulldecent
    fulldecent committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    8636d7b View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. Clean up Accept wording

    @fulldecent
    fulldecent committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    f53cc2d View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2018

  1. Clarify invalid deeds and counting

    @fulldecent
    fulldecent committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    6754461 View commit details
    Browse the repository at this point in the history

  2. Fix signature, thanks @Beskhue

    @fulldecent
    fulldecent committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    1ca7dfb View commit details
    Browse the repository at this point in the history

  3. Use interface keyword

    @fulldecent
    fulldecent committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    c0e6345 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2018

  1. Add deed name, rename return variables

    @fulldecent
    fulldecent committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    ea4ed40 View commit details
    Browse the repository at this point in the history

  2. Update deed word choice explanation

    @fulldecent
    fulldecent committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    6149ecc View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. remove deedName

    @fulldecent
    fulldecent committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    481e999 View commit details
    Browse the repository at this point in the history

  2. fix markdown language

    @fulldecent
    fulldecent committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    2b32af6 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Add implementation, thank you Nastassia Sachs

    @fulldecent
    fulldecent authored Feb 15, 2018
    Configuration menu
    Copy the full SHA
    7046c02 View commit details
    Browse the repository at this point in the history

  2. Provide illustration for scaling use case

    @fulldecent
    fulldecent authored Feb 15, 2018
    Configuration menu
    Copy the full SHA
    ddd2525 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Eat my words, add the transfer function

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    8743a22 View commit details
    Browse the repository at this point in the history

  2. Depend on 165

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    2b4971e View commit details
    Browse the repository at this point in the history

  3. Switch to latest Solidity compiler

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    f8fcf19 View commit details
    Browse the repository at this point in the history

  4. Add note about id choice

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    dd3396a View commit details
    Browse the repository at this point in the history

  5. Add note as 165 progresses through standardization

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    290f31c View commit details
    Browse the repository at this point in the history

  6. Add a second implementation

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    d45177e View commit details
    Browse the repository at this point in the history

  7. Add operators extension, a starting point

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    992bbff View commit details
    Browse the repository at this point in the history

  8. Specify functions that cannot throw

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    1d613ba View commit details
    Browse the repository at this point in the history

  9. Better address BC

    @fulldecent
    fulldecent authored Feb 16, 2018
    Configuration menu
    Copy the full SHA
    792bf05 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Harmonize this standard to results from the ETHDenver event

    @fulldecent
    fulldecent authored Feb 19, 2018
    Configuration menu
    Copy the full SHA
    1a1295c View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Use strong SHALL NOT language, thank you @carloschida

    @fulldecent
    fulldecent authored Feb 23, 2018
    Configuration menu
    Copy the full SHA
    e694c6d View commit details
    Browse the repository at this point in the history

  2. Update operator language

    @fulldecent
    fulldecent authored Feb 23, 2018
    1 Configuration menu
    Copy the full SHA
    ab00c60 View commit details
    Browse the repository at this point in the history

  3. Rename to assets

    @fulldecent
    fulldecent committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    21e0d24 View commit details
    Browse the repository at this point in the history

  4. Correct typos in JSON schema

    @fulldecent
    fulldecent authored Feb 23, 2018
    Configuration menu
    Copy the full SHA
    29cf090 View commit details
    Browse the repository at this point in the history

  5. Remove my name as interface author, that isn't helping anything

    @fulldecent
    fulldecent authored Feb 23, 2018
    Configuration menu
    Copy the full SHA
    868a208 View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @fulldecent
    fulldecent authored Feb 23, 2018
    Configuration menu
    Copy the full SHA
    39396a5 View commit details
    Browse the repository at this point in the history

  7. ERC-165 is now accepted, add strong support for 820 extension of 165 

    Thanks @eordano for bringing this up
    @fulldecent
    fulldecent authored Feb 23, 2018
    Configuration menu
    Copy the full SHA
    3442342 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2018

  1. Merge branch 'patch-2' into reconsider-deed-name

    @fulldecent
    fulldecent authored Feb 25, 2018
    Configuration menu
    Copy the full SHA
    7857e7d View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Allow to query the approved contracts

    @fulldecent
    fulldecent authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    2a56e50 View commit details
    Browse the repository at this point in the history

  2. Add transfer security, give everything else a once-over

    @fulldecent
    fulldecent authored Feb 26, 2018
    1 Configuration menu
    Copy the full SHA
    74dadcc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'patch-2' into reconsider-deed-name

    @fulldecent
    fulldecent authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    707cb55 View commit details
    Browse the repository at this point in the history

  4. More draft wording changes

    @fulldecent
    fulldecent authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    223e46c View commit details
    Browse the repository at this point in the history

  5. Link to mentioned Solidity bug

    @fulldecent
    fulldecent authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    7e83455 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Merge pull request #2 from fulldecent/reconsider-deed-name 

    Reconsider the word "deed"
    @fulldecent
    fulldecent authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    1eeddf7 View commit details
    Browse the repository at this point in the history

  2. Use a better magic value, clarify callback, thanks @abandeali1

    @fulldecent
    fulldecent authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    e847ffe View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. Bytes, not bytes[], thanks @sz-piotr

    @fulldecent
    fulldecent authored Feb 28, 2018
    Configuration menu
    Copy the full SHA
    89d0162 View commit details
    Browse the repository at this point in the history

  2. Update transfer naming and interface IDs

    @fulldecent
    fulldecent authored Feb 28, 2018
    Configuration menu
    Copy the full SHA
    2bddd12 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. Make getApproved constant view

    @fulldecent
    fulldecent authored Mar 1, 2018
    Configuration menu
    Copy the full SHA
    e855ea6 View commit details
    Browse the repository at this point in the history

  2. Update eip-721.md

    @fulldecent
    fulldecent authored Mar 1, 2018
    Configuration menu
    Copy the full SHA
    7304cca View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Correct reference name

    @fulldecent
    fulldecent authored Mar 2, 2018
    Configuration menu
    Copy the full SHA
    bed6978 View commit details
    Browse the repository at this point in the history

  2. Update eip-721.md

    @fulldecent
    fulldecent authored Mar 2, 2018
    Configuration menu
    Copy the full SHA
    3d22a00 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. Move all links to separate references section

    @fulldecent
    fulldecent authored Mar 7, 2018
    Configuration menu
    Copy the full SHA
    438c09e View commit details
    Browse the repository at this point in the history

  2. Correct whitespace

    @fulldecent
    fulldecent authored Mar 7, 2018
    Configuration menu
    Copy the full SHA
    19a5f63 View commit details
    Browse the repository at this point in the history

  3. Cosmetic change, remove return name, thank you @Nanolucas

    @fulldecent
    fulldecent authored Mar 7, 2018
    1 Configuration menu
    Copy the full SHA
    39687dc View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Fix broken link

    @fulldecent
    fulldecent authored Mar 8, 2018
    Configuration menu
    Copy the full SHA
    39067a2 View commit details
    Browse the repository at this point in the history