Use validator guide compute_on_chain_aggregate in testing
#3680
Conversation
| return Attestation( | ||
| aggregation_bits=aggregation_bits, | ||
| data=data, | ||
| committee_bits=committee_bits, | ||
| signature=signature, | ||
| ) |
There was a problem hiding this comment.
actually, I don't understand why this fixed the CI error...
without this fix, the result aggregate.data.target.epoch is 0 when it should be 2 in some tests.
/cc @protolambda, in case you can share some remerkleable wisdom. 🧙♂️
There was a problem hiding this comment.
not sure either, but I'll just assume there is some subtlety in how remerkleable initializes things
|
Is there any place in the tests where we would need to work with network aggregates? If not then we could add on chain aggregation step (call to |
|
The phase0 validator guide primarily provides a high-level description of the aggregate, but the I opened an issue to track it: #3683 |
|
LGTM! 👍 |
Thank @mkalinin for pointing it out! Validator guide impl is much more neat!