Remove SSZ unions #3906
Open
Remove SSZ unions #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew' imported but unused
|
unions were used in very old versions of sharding specs, and its possible we could use them in future iterations of the spec instead of deleting them, we could add a note that they are not part of a "core" or "minimum required functionality" SSZ implementation |
|
another data point: Portal uses unions in their networking specs here: https:/ethereum/portal-network-specs/blob/master/portal-wire-protocol.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSZ unions are not used and have never been used in any version of deployed consensus-layer Ethereum. Align spec with this.