EIP-7594: Specify inclusion proof function to run. #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For by root and by range requests checks, the exact function to run is specified for KZG commitments, but not for the inclusion proof. This PR aligns both checks.
|
Additional question: Should the Consequences could be quite dramatic if a client actually considers a block with data column sidecars with invalid inclusion proof and/or invalid KZG proofs as available. |
Precedent says no. For example, the equivalent check for consensus-specs/specs/deneb/p2p-interface.md Line 294 in 57483cb |
jtraglia
approved these changes
Oct 8, 2024
| @@ -223,7 +223,7 @@ Requests sidecars by block root and index. | |||
| The response is a list of `DataColumnIdentifier` whose length is less than or equal to the number of requests. | |||
| It may be less in the case that the responding peer is missing blocks or sidecars. | |||
|
|
|||
| Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted, has valid inclusion proof, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`. | |||
| Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted, has valid inclusion proof through `verify_data_column_sidecar_inclusion_proof`, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`. | |||
There was a problem hiding this comment.
This applies to both lines.
Suggested change
| Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted, has valid inclusion proof through `verify_data_column_sidecar_inclusion_proof`, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`. | |
| Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted through `verify_data_column_sidecar`, has valid inclusion proof through `verify_data_column_sidecar_inclusion_proof`, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For by root and by range requests checks, the exact function to run is specified for KZG commitments, but not for the inclusion proof.
This PR aligns both checks.