Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ropsten constantinople #1214

Merged
merged 8 commits into from
Oct 16, 2018
Merged

Fix/ropsten constantinople #1214

merged 8 commits into from
Oct 16, 2018

Conversation

zilm13
Copy link
Collaborator

@zilm13 zilm13 commented Oct 15, 2018

To be updated.

Not yet ready for merge.

Fixed: Constantinople fork has not started at correct block.
Finished by updating ropsten.json and improving net config logging to reduce mistakes in the future:

16:30:14.153 DEBUG [general]  Rendering net config from genesis org.ethereum.core.genesis.GenesisConfig@57c03d88 ...
16:30:14.153 DEBUG [general]  Block #0 => Frontier
16:30:14.154 DEBUG [general]  Block #0 => Homestead
16:30:14.156 DEBUG [general]  Block #10 => EIP158, chainId: 3
16:30:14.156 DEBUG [general]  Block #1700000 => Byzantium, chainId: 3
16:30:14.157 DEBUG [general]  Block #4230000 => Constantinople, chainId: 3
16:30:14.157 DEBUG [general]  Finished rendering net config from genesis org.ethereum.core.genesis.GenesisConfig@57c03d88
16:30:14.158 INFO [general]  Blockchain config BaseNetConfig{blockNumbers= #0 => HomesteadConfig, #10 => org.ethereum.config.net.JsonNetConfig$1@518caac3, #1700000 => org.ethereum.config.net.JsonNetConfig
$2@68034211, #4230000 => org.ethereum.config.net.JsonNetConfig$3@4f74980d (total: 4)}

@zilm13 zilm13 requested a review from mkalinin October 15, 2018 13:33
@zilm13
Copy link
Collaborator Author

zilm13 commented Oct 15, 2018

@mkalinin ready for review

Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkalinin mkalinin merged commit a207aee into develop Oct 16, 2018
@mkalinin mkalinin deleted the fix/ropsten-constantinople branch December 26, 2018 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants