Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated command line flags #22141

Closed
ligi opened this issue Jan 7, 2021 · 7 comments · Fixed by #22263
Closed

Remove deprecated command line flags #22141

ligi opened this issue Jan 7, 2021 · 7 comments · Fixed by #22263
Assignees

Comments

@ligi
Copy link
Member

ligi commented Jan 7, 2021

Rationale

  • simplification
  • subtraction
  • decrease complexity

This also includes:

  • we need to update puppeth as it is still using them
  • remove dead code paths
  • update documentation
@DGKSK8LIFE
Copy link

I'd be willing to make a PR fix for this! Let me make a list of deprecated geth flags and go from there.

@renaynay
Copy link
Contributor

renaynay commented Jan 7, 2021

Awesome @DGKSK8LIFE. Deprecated flags to be removed are located under the show-deprecated-flags command. Hope that helps!

@DGKSK8LIFE
Copy link

Now that I look at the codebase, this is a larger undertaking than I initially speculated. I also need some help navigating it. There's lots of interdependence within the code. Maybe I could open a draft PR and then we could work on addressing this issue from there?

@DGKSK8LIFE
Copy link

DGKSK8LIFE commented Jan 8, 2021

And if not, could someone explain where everything is in Ethereum's codebase related to flags? Thanks. (sorry I'm a new contributor to geth so don't completely understand its codebase yet)

@DGKSK8LIFE
Copy link

What do you think about the draft PR suggestion? @ligi

@ligi
Copy link
Member Author

ligi commented Jan 8, 2021

I think you should do something else then (e.g. test if #22145 works instead of telling others to do so)
IMHO when wanting to contribute in this project you should be familiar with the codebase or at least know how to get familiar.
I also think you should stop approving PRs when you are not familiar with the codebase.

@renaynay
Copy link
Contributor

renaynay commented Feb 3, 2021

Can we already deprecate most of the flags in the aliased section? Some where removed in May 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants