eth, eth/downloader: fix #1098, elevate empty hash errors to peer drops #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been seeing Empty hash sets being returned. Not sure if we are having a bug or not. Needs investigating. Right now it would drop of peers if this was merged. |
karalabe
force-pushed
the
drop-sync-peer-on-empty-hash
branch
from
0c78f8f
to
94e525a
Compare
|
PTAL |
obscuren
added a commit
that referenced
this pull request
Jun 5, 2015
eth, eth/downloader: fix #1098, elevate empty hash errors to peer drops
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Nov 8, 2022
…naries to releases page (ethereum#1100)
maoueh
added a commit
to streamingfast/go-ethereum
that referenced
this pull request
Nov 29, 2022
…naries to releases page (ethereum#1100) # Conflicts: # .github/generate_change_log.sh # .github/workflows/pre-release.yml # .github/workflows/release.yml # Dockerfile # accounts/abi/bind/bind_test.go # core/state_transition.go # eth/tracers/js/tracer_test.go # go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a peer sends us an empty hash set, there's something probably off with it. Just drop and try to sync with somebody else.