Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: zero temp variable in updateMeter #21470

Merged
merged 2 commits into from
Aug 21, 2020
Merged

metrics: zero temp variable in updateMeter #21470

merged 2 commits into from
Aug 21, 2020

Commits on Aug 21, 2020

  1. metrics: zero temp variable in updateMeter 

    Previously the temp variable was not updated properly after summing it to count.
This meant we had astronomically high metrics, now we zero out the temp whenever we
sum it onto the snapshot count
    @MariusVanDerWijden
    MariusVanDerWijden committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    61fade4 View commit details
    Browse the repository at this point in the history

  2. metrics: move temp variable to be aligned, unit tests 

    Moves the temp variable in MeterSnapshot to be 64-bit aligned because of the atomic bug.
Adds a unit test, that catches the previous bug.
    @MariusVanDerWijden
    MariusVanDerWijden committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    719ce5d View commit details
    Browse the repository at this point in the history