Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: aiming genesis when middle block is missing #22135

Merged
merged 2 commits into from
Jan 25, 2021
Merged

core: aiming genesis when middle block is missing #22135

merged 2 commits into from
Jan 25, 2021

Conversation

rjl493456442
Copy link
Member

Fixes #22129

holiman
holiman approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

DGKSK8LIFE
DGKSK8LIFE approved these changes Jan 7, 2021
View reviewed changes
Copy link

@DGKSK8LIFE DGKSK8LIFE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ligi
ligi reviewed Jan 12, 2021
View reviewed changes
core/blockchain.go Outdated Show resolved Hide resolved
@rjl493456442 rjl493456442 added this to the 1.10.0 milestone Jan 12, 2021
@holiman holiman merged commit 49cdcf5 into ethereum:master Jan 25, 2021
bulgakovk pushed a commit to bulgakovk/go-ethereum that referenced this pull request Jan 26, 2021
@rjl493456442 @bulgakovk
core: reset to genesis when middle block is missing (ethereum#22135)
243c2b2 
When a sethead/rewind finds that the targeted block is missing, it resets to genesis instead of crashing. Closes ethereum#22129
@quorumbot quorumbot mentioned this pull request Sep 3, 2021
Merged
9 tasks
@baptiste-b-pegasys baptiste-b-pegasys mentioned this pull request Sep 3, 2021
Closed
9 tasks
This was referenced Sep 23, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi left review comments

@holiman holiman holiman approved these changes

@DGKSK8LIFE DGKSK8LIFE DGKSK8LIFE approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Fast-synced node crushes
4 participants
@rjl493456442 @ligi @holiman @DGKSK8LIFE