internal/ethapi: merge CallArgs and SendTxArgs

[rjl493456442]

There are two transaction parameter structures defined in the codebase, although for different purposes.
But most of the parameters are shared. So it's nice to reduce the code duplication by merging them together.

[holiman]

LGTM

[holiman]

Previously, we had

// CallArgs represents the arguments for a call.
type CallArgs struct {
	From       *common.Address   `json:"from"`
	To         *common.Address   `json:"to"`
	Gas        *hexutil.Uint64   `json:"gas"`
	GasPrice   *hexutil.Big      `json:"gasPrice"`
	Value      *hexutil.Big      `json:"value"`
	Data       *hexutil.Bytes    `json:"data"`
	AccessList *types.AccessList `json:"accessList"`
}

And

type SendTxArgs struct {
	From     common.Address  `json:"from"`
	To       *common.Address `json:"to"`
	Gas      *hexutil.Uint64 `json:"gas"`
	GasPrice *hexutil.Big    `json:"gasPrice"`
	Value    *hexutil.Big    `json:"value"`
	Nonce    *hexutil.Uint64 `json:"nonce"`
	// We accept "data" and "input" for backwards-compatibility reasons. "input" is the
	// newer name and should be preferred by clients.
	Data  *hexutil.Bytes `json:"data"`
	Input *hexutil.Bytes `json:"input"`

	// For non-legacy transactions
	AccessList *types.AccessList `json:"accessList,omitempty"`
	ChainID    *hexutil.Big      `json:"chainId,omitempty"`
}

These are now replaced by

type TransactionArgs struct {
	From     *common.Address `json:"from"`
	To       *common.Address `json:"to"`
	Gas      *hexutil.Uint64 `json:"gas"`
	GasPrice *hexutil.Big    `json:"gasPrice"`
	Value    *hexutil.Big    `json:"value"`
	Nonce    *hexutil.Uint64 `json:"nonce"`

	// We accept "data" and "input" for backwards-compatibility reasons.
	// "input" is the newer name and should be preferred by clients.
	// Issue detail: https:/ethereum/go-ethereum/issues/15628
	Data  *hexutil.Bytes `json:"data"`
	Input *hexutil.Bytes `json:"input"`

	// For non-legacy transactions
	AccessList *types.AccessList `json:"accessList,omitempty"`
	ChainID    *hexutil.Big      `json:"chainId,omitempty"`
}

One thing to note here is that now, From *common.Address becomes an optional field, which can be nil. This may bite us somewhere, since we're now dealing with a pointer which we previously did not

[holiman]

Addendum: I think it's fine the way Gary handled it

[holiman]

@fjl want to TAL again? This one might bitrot if we don't merge it soonish

[fedekunze]

Hi, just wondering, is there any reason why this type is located on the internal package? I think it would be great to have all the RPC types public

[fjl]

@fedekunze The types in internal/ethapi are specific to the server side of the API.
We don't want to expose it to the public because the client side should not depend
on the server backend.