Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient/gethclient: RPC client wrapper for geth-specific API #22977

Merged
merged 10 commits into from
Jun 30, 2021
Merged

ethclient/gethclient: RPC client wrapper for geth-specific API #22977

merged 10 commits into from
Jun 30, 2021

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Jun 1, 2021 •
edited
Loading

This PR adds the gethclient package which implements geth specific rpc calls

Huge shoutout to @fxfactorial and @p4u for their work that I used here.

TODO:

  • Docs
  • implement additional geth specific RPC calls

closes #22299
closes #21143

@MariusVanDerWijden
gethclient: implement client for geth specific functions
ecdb7f5 
This commit adds the package gethclient which is similar to the ethclient
and implements some geth specific functionality.
Big shoutout to @fxfactorial and @p4u for implementing the functionality
in ethclient which I now ported to gethclient.
@MariusVanDerWijden MariusVanDerWijden mentioned this pull request Jun 1, 2021
Closed
@fjl
Copy link
Contributor

fjl commented Jun 1, 2021 •
edited
Loading

The gethclient package should be moved to the ethclient directory, i.e. import path "github.com/ethereum/go-ethereum/ethclient/gethclient". The reason being that we have enough top-level directories already, don't want to add more unless there is a very good reason for it.

fjl
fjl reviewed Jun 1, 2021
View reviewed changes
ethclient/ethclient.go Outdated Show resolved Hide resolved
@fjl fjl changed the title gethclient: Implement geth specific functionality ethclient/gethclient: RPC client wrapper for geth-specific API Jun 1, 2021
@rjl493456442 rjl493456442 mentioned this pull request Jun 2, 2021
Closed
@fjl
Copy link
Contributor

fjl commented Jun 2, 2021

In general, we should avoid exposing hexutil-typed fields in Go API surface. To do this, we would have to use gencodec to create marshaling wrappers for all structs with such fields.

This was referenced Jun 9, 2021
Closed
Closed
@MariusVanDerWijden
Copy link
Member Author

@fjl I removed the hexutil types in the api surface here: 6ac1181
Instead of using gencodec I wrote some internal types + functionality to convert them. That seemed a bit easier for me. It's a bit less maintainable though I think. What do you think, should I leave it like this or use gencodec?

@MariusVanDerWijden MariusVanDerWijden marked this pull request as ready for review June 24, 2021 13:01
@Jolly23
Copy link
Contributor

Jolly23 commented Jun 26, 2021

nice job!

@MariusVanDerWijden MariusVanDerWijden mentioned this pull request Jun 29, 2021
Closed
@fjl fjl merged commit acdf923 into ethereum:master Jun 30, 2021
@fjl fjl added this to the 1.10.5 milestone Jun 30, 2021
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
6e60422 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
1292e75 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
fcb4802 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
bde3377 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
e10e7da 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
3b17afe 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
8703408 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
bd5123d 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
f92c62a 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
ff2aef3 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
d48d1b3 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
3fab55b 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
5227383 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
96a2d2f 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
cae30cf 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
960363d 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
7cf5b26 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
2401b34 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
9aae3a6 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
c922c64 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
958a2e0 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
c2ec8fd 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
c5f9e11 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
89fad85 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
c0cdc8f 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
636c4e3 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
f293e2f 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
25bbf54 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
a58a15e 
…eum#22977)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
ethclient/gethclient: RPC client wrapper for geth-specific API (ether…
efec8ed 
…eum#22977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.5
Development

Successfully merging this pull request may close these issues.

Watching pendingTransactions with go-ethereum as a library JSON_RPC eth_pendingTransactions Filtering
8 participants
@MariusVanDerWijden @fjl @Jolly23 @mpereiraesaa @mindfulme @Ayoseun @jsvisa @fxfactorial