Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix stopping websocket rpc.Server #23211

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

Evolution404
Copy link
Contributor

No description provided.

@Evolution404 Evolution404 requested a review from fjl as a code owner July 15, 2021 02:20
@fjl fjl changed the title node/rpcstack.go 'doStop' gets wrong 'wsHandler' node: fix stopping websocket rpc.Server Jul 15, 2021
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fjl fjl merged commit 89fde59 into ethereum:master Jul 15, 2021
@fjl fjl added this to the 1.10.6 milestone Jul 15, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Jul 28, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants