core/rawdb: close database in test to avoid goroutine leak #23287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesxsh
requested review from
holiman,
karalabe and
rjl493456442
as code owners
fjl
reviewed
Jul 29, 2021
core/rawdb/accessors_chain_test.go
Outdated
| @@ -494,6 +494,9 @@ func TestAncientStorage(t *testing.T) { | |||
| if blob := ReadTdRLP(db, fakeHash, number); len(blob) != 0 { | |||
| t.Fatalf("invalid td returned") | |||
| } | |||
| if err := db.Close(); err != nil { | |||
There was a problem hiding this comment.
Would be better to use defer db.Close() near NewDatabaseWithFreezer
fjl
changed the title
holiman
approved these changes
Aug 7, 2021
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 15, 2021
…23287) * add db close to avoid goroutine leak * core/rawdb: move close to defer Co-authored-by: Martin Holst Swende <[email protected]>
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…23287) * add db close to avoid goroutine leak * core/rawdb: move close to defer Co-authored-by: Martin Holst Swende <[email protected]>
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In core/rawdb/accessors_chain_test.go:435
db never close so goroutine created at core/rawdb/database.go:199 never return: