Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymExec: propogate constraints from vm to output expression #268

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

d-xo
Copy link
Collaborator

@d-xo d-xo commented May 31, 2023

Description

We weren't including the constraints from the vm in the props of leaves in the final expressions output during symbolic execution. In practice this was mostly affecting abi decoding, and constraints on variables in semi structured calldata.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo d-xo requested a review from zoep May 31, 2023 14:31
Copy link
Collaborator

@zoep zoep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@d-xo d-xo merged commit 886c11f into main Jun 1, 2023
@d-xo d-xo deleted the propogate-constraints branch June 1, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants