EVM: finalize: fix handling of symbolic returndata #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We produced a `Partial` node with a message "runtime code cannot have an abstract length" if we could not determine a concrete size for returndata when finalizing a transaction. This changes gates that check so it is only made if we are actually in a create transaction (which is the only context where it is valid).
|
Wow |
msooseth
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We produced a
Partialnode with a message "runtime code cannot have an abstract length" if we could not determine a concrete size for returndata when finalizing a transaction. This change gates that check so it is only made if we are actually in a create transaction (which is the only context where it is valid).Description
Checklist