Either SMT so we can gracefully handle SMT generation issues such as CopySlice #591
+383
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
maybe-smt
branch
3 times, most recently
from
cf16288
to
3d7c720
Compare
msooseth
force-pushed
the
maybe-smt
branch
2 times, most recently
from
ae10a03
to
cc26d4d
Compare
msooseth
changed the title
Instead, collect errors, and gracefully display a count
msooseth
changed the title
msooseth
commented
Oct 10, 2024
Comment on lines
+263
to
+264
| when (any isTimeout res || any isError res) $ do | ||
| putStrLn $ "But " <> (show $ length $ filter isTimeout res) <> " timeout(s) and/or " <> (show $ length $ filter isError res) <> " error(s)/incomplete execution(s) occurred" |
There was a problem hiding this comment.
Let me know if you have an idea how to categorize these. Note that we COULD try "grouping together" the types of results. They should group easily (I think) and then we could display: N number of timeouts, K number of copyslice, Z number of SMT solver deaths, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows us to give results even for cases where some of the SMT cannot be generated due to symbolic copyslice. Then, we collect the errors and we continue running. This allows us to be more user-friendly and deal with more cases.
Please simply update (i.e. push into) this PR any changes you'd like to see about it!
Checklist