Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the blockhash test for constantinople. #4805

Closed
ekpyron opened this issue Aug 13, 2018 · 5 comments
Closed

Re-enable the blockhash test for constantinople. #4805

ekpyron opened this issue Aug 13, 2018 · 5 comments

Comments

@ekpyron
Copy link
Member

ekpyron commented Aug 13, 2018

Came up in #4799.

For constantinople the blockhash opcode seems to always return zero.
This is probably due to us setting the constantinople fork block to zero and resetting the chain to block zero before each test, which seems to break the blockchain contract in aleth (introduced in EIP96). Either our test setup has to be adjusted or aleth should support blockhash in the configuration used for our tests.

Corresponding issue in aleth: ethereum/aleth#5184

@ekpyron
Copy link
Member Author

ekpyron commented Aug 13, 2018

Pre-deploying the blockhash contract by adding it to the pre-defined accounts during genesis in RPCSession.cpp seems to help, but causes issues with other tests (https://circleci.com/gh/ethereum/solidity/30991).

@chriseth
Copy link
Contributor

@ekpyron is this still the case?

@ekpyron
Copy link
Member Author

ekpyron commented Dec 13, 2018

It's not the case anymore, no, but the blockhash is still disabled for "< constantinople". Since we require newer aleth versions now anyways, we should reenable it. I'll rename this and create a suitable PR that closes this then.

@ekpyron ekpyron changed the title blockhash always returns zero in constantinople semantics tests Re-enable the blockhash test for constantinople. Dec 13, 2018
@chriseth
Copy link
Contributor

chriseth commented Mar 4, 2019

I believe this has been done in #6145

@ekpyron
Copy link
Member Author

ekpyron commented Mar 4, 2019

Confirmed: this was done in #6145.

@ekpyron ekpyron closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants