Force interface functions as external (0.5.0) #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
interface-external
branch
2 times, most recently
from
4df1af5
to
a4e1275
Compare
axic
commented
Oct 6, 2017
| char const* text = R"( | ||
| pragma experimental "v0.5.0"; | ||
| interface I { | ||
| function f() private; |
axic
force-pushed
the
interface-external
branch
from
a4e1275
to
0031255
Compare
axic
force-pushed
the
interface-external
branch
from
0031255
to
c45e556
Compare
|
Hm, I would have said that no visibility specifier is allowed and it is external by default, but I'm also fine with this. |
chriseth
approved these changes
Oct 6, 2017
|
Ok, having thought about it again: People don't know what the defaults are, especially not if there is no obvious default, so probably better to force a keyword. |
This was referenced Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2330.