Correct notice about which macOS versions are supported #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jan 24, 2018
scripts/install_deps.sh
Outdated
| @@ -86,7 +86,7 @@ case $(uname -s) in | |||
| ;; | |||
| *) | |||
| echo "Unsupported macOS version." | |||
| echo "We only support Mavericks, Yosemite and El Capitan, with work-in-progress on Sierra." | |||
| echo "We only support Mavericks, Yosemite and El Capitan, with work-in-progress on High Sierra." | |||
There was a problem hiding this comment.
This removes Sierra from the supported list.
|
@axic Thank you, corrected. Now Sierra is shown as supported and the High Sierra is the work in progress. |
axic
approved these changes
Jan 24, 2018
|
I'm not sure though what "work-in-progress" means there :) Do you by any chance have High Sierra? If so, does it work out of the box? |
|
I have High Sierra and it works out of the box with the instructions provided. (I just overrode the version check.) I will create a separate PR in a moment to fix that. This PR is zero risk so you can merge now. That PR will be higher risk so more people can review it further before merge. |
|
The other related PR #3430 |
|
I'll go with the other one. Someone at this point would've complained if it wasn't working. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change any code. The code already shows Sierra is supported. I have changed just the message to show that the unsupported version is High Sierra (aka macOS 10.13, the next version after Sierra).