Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert in CREATE in init code, followed by returndatasize/copy #419

Merged
merged 2 commits into from
Mar 1, 2018

Conversation

pirapira
Copy link
Member

@pirapira pirapira commented Feb 27, 2018

@pirapira pirapira merged commit 61185fe into develop Mar 1, 2018
@pirapira pirapira deleted the init-create-revert branch March 1, 2018 14:25
@veox
Copy link

veox commented Sep 5, 2018

For ref: py-evm had a hiccup on this one.

Here's what I think is going on it the test: ethereum/py-evm#1224 (comment).

From gitter chat, the test rationale might be focusing on pre-Byzantium execution, not Byzantium itself:

maybe [Yoichi] was afraid that returndatasize might be 0 and so this way he checks that transaction fails on <Byzantium .

The "weird" part about the test is having a {zero-balance, no-code, zero-nonce, some-storage} account in the pre section:

"pre" : {
"0x6295ee1b4f6dd65047762f924ecd367c17eabf8f" : {
"balance" : "0x00",
"code" : "",
"nonce" : "0x00",
"storage" : {
"0x00" : "0x01"
}
},

The call to REVERT fails on pre-Byzantium, but is expected to have the storage filled on Byzantium:

"0x6295ee1b4f6dd65047762f924ecd367c17eabf8f" : {
"balance" : "0x00",
"code" : "",
"nonce" : "0x02",
"storage" : {
"0x00" : "0x20",
"0x01" : "0x112233"
}
},

The difference between py-evm and the test-as-specified is in gas use, and is discussed in more detail in the py-evm PR (first link of this comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants