Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gasLimit issue in GeneralStateTests #590

Merged
merged 15 commits into from
Mar 23, 2019
Merged

fix gasLimit issue in GeneralStateTests #590

merged 15 commits into from
Mar 23, 2019

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Mar 6, 2019

Fix tests that error on blockchain logic (when run as a blockchain test via rpc)
Move blockchain specific tests from GeneralStateTests to BlockcainTests

@winsvega
Copy link
Collaborator Author

retesteth GeneralStateTests run on current aleth (8 threads)

*** Execution time stats
Total Time:                                       : 872               
stStaticCall                                  time: 155.571           
stTransactionTest                             time: 72.3203           
stPreCompiledContracts                        time: 65.4258           
stZeroKnowledge                               time: 60.3004           
stBadOpcode                                   time: 49.4752           
stRevertTest                                  time: 26.5054           
stZeroKnowledge2                              time: 24.4013           
stRandom                                      time: 24.3049           
stStackTests                                  time: 24.2651           
stRandom2                                     time: 18.7883           
stCreateTest                                  time: 16.2233           
stPreCompiledContracts2                       time: 16.1977           
stSystemOperationsTest                        time: 16.1401           
stMemoryTest                                  time: 13.5611           
stCallCodes                                   time: 12.7126           
stLogTests                                    time: 12.5739           
stCallDelegateCodesHomestead                  time: 12.395            
stZeroCallsTest                               time: 12.1419           
stCallDelegateCodesCallCodeHomestead          time: 12.0286           
stArgsZeroOneBalance                          time: 11.9778           
stReturnDataTest                              time: 11.874            
stMemoryStressTest                            time: 11.8697           
stEIP150singleCodeGasPrices                   time: 11.8379           
stDelegatecallTestHomestead                   time: 11.5628           
stChangedEIP150                               time: 11.4724           
stWalletTest                                  time: 11.2248           
stCallCreateCallCodeTest                      time: 11.1469           
stNonZeroCallsTest                            time: 11.0701           
stInitCodeTest                                time: 10.9538           
stRefundTest                                  time: 10.5508           
stSpecialTest                                 time: 10.4711           
stTransitionTest                              time: 10.0046           
stZeroCallsRevert                             time: 9.79782           
stAttackTest                                  time: 9.76891           
stEIP150Specific                              time: 9.69208           
stMemExpandingEIP150Calls                     time: 9.6656            
stSolidityTest                                time: 9.63558           
stBugs                                        time: 8.68921           
stEIP158Specific                              time: 8.40582           
stRecursiveCreate                             time: 7.82401           
stCodeSizeLimit                               time: 7.63982           
stCodeCopyTest                                time: 7.53228           
stHomesteadSpecific                           time: 7.3906            
stExample                                     time: 6.49506           

@winsvega
Copy link
Collaborator Author

testeth passing the refilled tests.
the test logic didn't changed. thus blockchain version of general state tests is not required.
the next step is full tests regeneration by testeth for retesteth. all tests must include additional hash of a post state with mining rewards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant