Fix page location reading in Chrome #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome started setting the location of the iframe containing the bulk of the client code slightly differently to that one of the top-level window in some unknown version; the iframe does now not contain the fragment identifier of the top-level window, which some things (including custom themes and development the frontend against upstream backends) depended on. Ironically, a follow-up to 3ba8a2e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome started setting the location of the iframe containing the bulk
of the client code slightly differently to that one of the top-level
window in some unknown version; the iframe does now not contain the
fragment identifier of the top-level window, which some things
(including custom themes and development the frontend against upstream
backends) depended on.
Ironically, a follow-up to 3ba8a2e.