Fix parallel preloading with 'fake' transaction behaviour #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @evadne!
Was playing around with this and tried running multiple preloads in parallel
Repo.preload([:employee, :customer])
and it was failing with the following error:Took a look and realized the adapter is missing the Ecto.Adapter.Transaction behaviour.
I presume this is because there is no transaction mechanism we can use for :ets?
Anyway - figured we could trick Ecto into thinking we are never in a transaction - and the parallel preload now works as expected.
Might be some side effects I have not run into, thoughts?