Fix/#CSV Injection Vulnerability Fixes #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
bvenceslas
changed the title
rahul-rocket
changed the title
evereq
reviewed
Jan 26, 2022
evereq
reviewed
Jan 26, 2022
evereq
reviewed
Jan 26, 2022
evereq
reviewed
Jan 26, 2022
…raduora into fix-csv-injection
bvenceslas
force-pushed
the
fix-csv-injection
branch
from
67df525
to
72690eb
Compare
evereq
reviewed
Jan 26, 2022
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SWAGGERUIDIST-2314884
…e0e63fe36 [Snyk] Security upgrade swagger-ui-express from 4.1.6 to 4.2.0
Bumps [node-fetch](https:/node-fetch/node-fetch) from 2.6.2 to 2.6.7. - [Release notes](https:/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.2...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…-fetch-2.6.7 build(deps): bump node-fetch from 2.6.2 to 2.6.7 in /api
evereq
added a commit
that referenced
this pull request
Jan 29, 2022
* fixed the csv injection vulnerability * fix: remove default password * refactored the logic * added some risky characters to escape * removed the console.log * fix the deepscan warning * fix: api/package.json & api/yarn.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SWAGGERUIDIST-2314884 * build(deps): bump node-fetch from 2.6.2 to 2.6.7 in /api Bumps [node-fetch](https:/node-fetch/node-fetch) from 2.6.2 to 2.6.7. - [Release notes](https:/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.2...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * fixed conflicts from package.json :wq * refactored the logic * fixed conflict * removed the console.log * added some comments on the refactored code * added test for the cleaning risky characters * fix: increased default jest timeout * fix: deepscan & increased jest timeout * fix: formatting with prettier * fix: csv injection matching with first character of csv cell * fix: formatting using Prettier * fix: deepscan * feat: split unit and e2e tests as separate jobs * fix: ops * feat: update Circle to use Orbs * fix: run tests in feature branches too * fix: scripts permissions Co-authored-by: RAHUL RATHORE <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Ruslan Konviser <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/e3b746003e88412f8b5ffbddde670106